-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Key value interface, attribute paths, attribute caching #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-generate current year in license
sensitive ops twice with a caching writer)
TODO implement updates in create and remove methods
TODO shouldn't readers do that too?
TODO fails deepList test for a mix of test and implementation issues
# Conflicts: # README.md # pom.xml
abstracts further to platform dependent separation strings (e.g. "/" vs "\"). The resulting path string is now strictly a platform dependent path and should not be used in code where a platform independent string is expected. Thanks to the Windows FileSystem implementation accepting "/" separated paths, this should not cause pracitcal issues at this time but we may have to change the API to support other FileSystems (e.g. passing paths along as components instead of strings or settling on a nio Path like object).
better on key value stores that do not really have paths. TODO check for leftover redundant path creation, that wouldn't break things but makes an unnecessary exists test
Feat/windows actions
… incompatible type
This reverts commit ccda98e
* N5Reader * LockedChannel * KeyValueAccess * FileSystemKeyValueAccess
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #77